Skip to content

chore: Pin NodeJS version to the one in package.json#33685

Merged
sharat87 merged 2 commits intoreleasefrom
chore/pin-node-version
May 23, 2024
Merged

chore: Pin NodeJS version to the one in package.json#33685
sharat87 merged 2 commits intoreleasefrom
chore/pin-node-version

Conversation

@sharat87
Copy link
Copy Markdown
Member

@sharat87 sharat87 commented May 23, 2024 •
edited by github-actions bot
Loading

The newer NodeJS version 20.13 requires a more recent version of glibc, one which isn't available on Ubuntu 20.04 yet. We need to stick to NodeJS v20.11 until we can update Ubuntu itself to 22.04, or the updated glibc shows up in Ubuntu 20.04.

Pinning NodeJS version for now to unblock.

/test sanity

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9203860279
Commit: 4d0f606
Cypress dashboard url: Click here!
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 23, 2024
@sharat87 sharat87 marked this pull request as ready for review May 23, 2024 07:07
@sharat87 sharat87 requested a review from pratapaprasanna as a code owner May 23, 2024 07:07
@sharat87 sharat87 requested review from KelvinOm and mohanarpit May 23, 2024 07:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 23, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent update to the Docker environment configuration in deploy/docker/base.dockerfile streamlines the NodeJS installation process by dynamically determining the required NodeJS version from the client app's package.json. This change enables automatic downloading and setup of the precise NodeJS version specified by the application, ensuring alignment between the development environment and application requirements.

Changes

File Change Summary
deploy/docker/base.dockerfile Updated NodeJS installation process to dynamically fetch the version from the client app's package.json.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 82a9931 and 4d0f606.
Files selected for processing (1)
  • deploy/docker/base.dockerfile (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • deploy/docker/base.dockerfile

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sharat87 sharat87 marked this pull request as draft May 23, 2024 07:08
@sharat87 sharat87 marked this pull request as ready for review May 23, 2024 07:17
@trishaanand trishaanand added the ok-to-test Required label for CI label May 23, 2024
@sharat87 sharat87 merged commit 0f167af into release May 23, 2024
@sharat87 sharat87 deleted the chore/pin-node-version branch May 23, 2024 07:21
@coderabbitai coderabbitai bot mentioned this pull request Nov 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trishaanand trishaanand trishaanand approved these changes

@pratapaprasanna pratapaprasanna Awaiting requested review from pratapaprasanna

@mohanarpit mohanarpit Awaiting requested review from mohanarpit

@KelvinOm KelvinOm Awaiting requested review from KelvinOm

Assignees

No one assigned

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sharat87 @trishaanand